twostraws / ControlRoom

A macOS app to control the Xcode Simulator.
MIT License
5.75k stars 306 forks source link

M1 Support? #118

Closed hedlynogan closed 8 months ago

hedlynogan commented 3 years ago

Hi Paul, I am a huge fan and based on your review I went and bought a M1 Mac Mini. However, I guess you have not tried to build this on your M1 or you would notice it would fail with the following errors.

/Users/nedh/Develop/PaulHudson/ControlRoom/ControlRoom/Simulator UI/ControlScreens/LocationView.swift:41:17: error: cannot find 'Map' in scope Map(coordinateRegion: $currentLocation, annotationItems: annotations) { location in ^~~ /Users/nedh/Develop/PaulHudson/ControlRoom/ControlRoom/Simulator UI/ControlScreens/LocationView.swift:42:21: error: cannot find 'MapPin' in scope MapPin(coordinate: CLLocationCoordinate2D(latitude: location.latitude, longitude: location.longitude), tint: .red)

It builds without issues on my i9. I am running Xcode 12.4 and Big Sur 11.3 Beta.

Any idea when you will support M1? I don't see any claim in the README?

hedlynogan commented 3 years ago

Paul said: "That's odd – I don't think that's an M1 issue. Others have reported it building just fine with M1."

I moved this to it's own issue and copied your response Paul.

I tried removing and a fresh clone, toggling Mac | or Rosetta, remove deriviedData, doesn't make a difference, won't build on my M1, noticing other odd behavior in system preferences and app file dialogs hanging, caused real concern.

However, I took a async/await preview class and I forgot to uncheck the Swift Development Snapshot, went back to Xcode 12.4 Toolchain and it worked. My bad, sorry.

nashysolutions commented 3 years ago

Runs fine for me

See bottom of this ticket

https://github.com/twostraws/ControlRoom/issues/103

nashysolutions commented 3 years ago

https://twitter.com/vatsal_manot/status/1360530574897606656?s=20

Harry-KNIGHT commented 8 months ago

Works fine on my MacBook Air M1 and my MacBook M1 Pro.

I think this issue can be closed.

twostraws commented 8 months ago

Thank you!