Add ffmpeg compression option for recorded videos

twostraws / ControlRoom

A macOS app to control the Xcode Simulator.

MIT License

5.75k stars 306 forks source link

Add ffmpeg compression option for recorded videos #131

Closed bamx23 closed 3 years ago

bamx23 commented 3 years ago

Simctl records relatively large video files that can be easily compressed. From my experience: the video file can be 10 times smaller without significant loss in quality.

I'm not an expert in ffmpeg and not sure if such compression can be done using AVFoundation. If you think that external implicit dependency on ffmpeg isn't a good idea I can investigate if AVFoundation can do the same compression itself(and I expect it should). Anyway, I'm open to discussion.

twostraws commented 3 years ago

Sorry for taking such a long time to review this! I think lets merge in ffmpeg for now, and if someone wants to take a shot at doing it with AVFoundation or similar at least they have something to build on. I do think ditching the extra dependency is welcome, though, so you're welcome to try!