Closed erwinmaza closed 3 years ago
Screenshots of the new UI including file drop targets
This looks like a really nice set of changes! One thing I'm not sure about is the "Files Path" UI – it's in some sort of group box by itself, presumably for the drag and drop. I'm not sure if there's a better way that could be presented?
Thanks Paul.
Yes, the border around the Files Path
is intended to convey the size of the drop target. Also it gives visual indication that the drop will succeed by changing color when the dragged files hover over it.
Potentially both of those objectives could be met by using different background colors instead of a border. But the look and hover effects are subjective, and are easy enough to fiddle with by changing this modifier: https://github.com/twostraws/ControlRoom/blob/9a8accae59927b070be07be1d0e1733a6af5e740/ControlRoom/Simulator%20UI/ControlScreens/SystemView.swift#L151
Feel free to adjust that (or any part of this PR) to your liking, as you are probably in the best position to determine what is a better way to present something in your app. I imagine you'll want to apply the same effect to the multi-simulator drop target as well for consistency: https://github.com/twostraws/ControlRoom/blob/9a8accae59927b070be07be1d0e1733a6af5e740/ControlRoom/Main%20Window/SplitLayoutView.swift#L42
Okay! I'll go ahead and merge this, but if anyone has suggestions for how the layout can be improved I'd love to see them – I think just a little bit of extra styling might go a long way.
Hello @twostraws, and thanks for open sourcing this utility. I found it a great way to practice SwiftUI and learn how to do new things, by breaking, fixing, and expanding on a working app.
This PR's main objective is to make it easy to add files to a simulator's local files directory. There are now 4 ways to accomplish this:
Via the simulator's
System
tab:Open in Finder
to open a finder window at the simulator'sFile Provider Storage
folder on disk.Open in Terminal
to open a Terminal window at the simulator'sFile Provider Storage
folder on disk.Files Path
section, then drop to copy the items.You can also copy the full path to your clipboard.
Via the sidebar:
For drag and drop, I convey success or failure to the user by playing a "success" or "failure" system sound for each file for each simulator. Note: to allow the user to distinguish the different sounds, there is a 1 second delay between copy attempts. This will not scale well if the user drops a large folder structure.
This PR also adds
Copy
,Open in Finder
andOpen in Terminal
for the simulator's root data path. It also allows you toCopy
its Device ID.I hope you find this functionality useful. Let me know if you'd like to see changes.
Erwin