search

twostraws / ControlRoom

A macOS app to control the Xcode Simulator.
MIT License
5.71k stars 306 forks source link

Use preferences to set terminal app path #143

Closed fmortens closed 2 years ago

fmortens commented 2 years ago

Hi!,

I noticed that the file path to the Terminal app for opening in Terminal is hard coded to the Terminal.app.

I suggest maybe allowing users to specify the path to the app of their choosing. I for one use iTerm2 and would very much like to be given the option to use the same here as well.

This PR will add the path to the preferences and use the UserDefaults to store whatever the user specifies so it can be used for the "Open in Terminal" feature.

Skjermbilde 2022-01-04 kl 14 14 36

I have run the tests and also made sure SwiftLint is happy :)

twostraws commented 2 years ago

This is a great change – thank you!