search

twostraws / ControlRoom

A macOS app to control the Xcode Simulator.
MIT License
5.71k stars 306 forks source link

feat: Xcode 15 localization #181

Open Harry-KNIGHT opened 7 months ago

Harry-KNIGHT commented 7 months ago

Use Xcode 15 localization for have all localized into one file and translate this big open source project to a larger audience of developers

twostraws commented 7 months ago

Hello! Thank you for this – it's an important step forward. Before I merge, I just want to check why we're using NSLocalizedString. As this project is written almost entirely in SwiftUI, I'm rather hopeful we get automatic localization through the framework.

Harry-KNIGHT commented 7 months ago

Hello! Thank you for this – it's an important step forward. Before I merge, I just want to check why we're using NSLocalizedString. As this project is written almost entirely in SwiftUI, I'm rather hopeful we get automatic localization through the framework.

@twostraws be careful, do not merge at this MR step, I opened it as draft for you can see my proposal, if this way of doing it is okay for you I will make it for all text and localized already existing.

If you have any advices I'll take them