search

twostraws / ControlRoom

A macOS app to control the Xcode Simulator.
MIT License
5.8k stars 306 forks source link

[FR] Make "Uninstall App" button be confirmable #26

Closed vandres closed 4 years ago

vandres commented 4 years ago

While testing the Tool, I accidentally uninstalled the app twice. I would suggest to move the button away from "Send Push" or make it at least so, that it needs to be confirmed.

zengpeici commented 4 years ago

While testing the Tool, I accidentally uninstalled the app twice. I would suggest to move the button away from "Send Push" or make it at least so, that it needs to be confirmed.

dose it mean that 'could not uninstall app'?

vandres commented 4 years ago

@zengpeici Uninstalling works - too good I would mean :D I think it would be a better usability to move the button away from the current location, because it can to easily be hit on accident. Or at least a confirmation ala "Really uninstall?" should come

zengpeici commented 4 years ago

@vandres good suggestion.

MarioIannotta commented 4 years ago

@davedelong I moved the button in https://github.com/twostraws/ControlRoom/pull/30. Do we still want to add the confirmation alert?

davedelong commented 4 years ago

Yes, let's re-purpose this as making it a confirmable action

davedelong commented 4 years ago

Fixed by #39