Contextual actions - Githubissues

twostraws / ControlRoom

A macOS app to control the Xcode Simulator.

MIT License

5.77k stars 304 forks source link

Contextual actions #45

Closed davedelong closed 4 years ago

davedelong commented 4 years ago

This adds contextual actions to rename, clone, and delete simulators.

Some notes:

A booted simulator cannot be cloned. Therefore if the simulator is booted, the "Clone..." command is disabled
This contextual menu is on the SidebarSimulatorView, but it is only present when zero or one simulator is selected. If multiple simulators are selected, the contextual menu is disabled and the "Delete..." context menu on the sidebar takes precedence.

davedelong commented 4 years ago

Fixes #34 . Fixes #35

MarioIannotta commented 4 years ago

I tried it and it looks great. I noticed just the following issue: after when cloning a simulator (A) and changing the name (to B), the list is updated but the new simulator name is not updated (is A instead of B). After relaunching the application the name is properly displayed. I looked into the code and did some debugging and the model is right, SimulatorSidebarView receive the right object but for some reason the ui is not updated.