search

twostraws / ControlRoom

A macOS app to control the Xcode Simulator.
MIT License
5.77k stars 304 forks source link

Location simulation working on Default simulator #47

Closed stefanomondino closed 4 years ago

stefanomondino commented 4 years ago

fixes #46

Unfortunately, I had to bring down the SimulatorsController to the LocationView to obtain a list of active simulators and broadcast the coordinates notification to all of them.

davedelong commented 4 years ago

I wonder if we should make the SimulatorsController be an EnvironmentObject 🤔

stefanomondino commented 4 years ago

@davedelong nice call! I still don't fully get how Environment Objects are supposed to work, this helped me understand it better!

twostraws commented 4 years ago

Is this ready to merge?

stefanomondino commented 4 years ago

@twostraws it is now. I've reverted back the declaration of SimulatorsController from Env object to ObservedObject to avoid lots of conflicts with other commits. I think that @davedelong suggestion was good but is really hard to implement in a specific pull request like this.