search

twostraws / ControlRoom

A macOS app to control the Xcode Simulator.
MIT License
5.77k stars 304 forks source link

Replace Icons with Vector Assets #55

Closed pluddy closed 4 years ago

pluddy commented 4 years ago

This PR updates all symbols in the app to vector assets. This should result in better scaling for retina resolutions, and future reuse at different sizes.

Note: SwiftUI seems to have a problem right now with resizing images inside Picker items. I am injecting an NSImage with proper size as a workaround.

screenshot

image
davedelong commented 4 years ago

These look fabulous! Are these icons you created yourself? If so, can you include the source files in the "Working" directory and delete the .pxd documents for the old icons?

pluddy commented 4 years ago

These look fabulous! Are these icons you created yourself? If so, can you include the source files in the "Working" directory and delete the .pxd documents for the old icons?

Thanks @davedelong! the wifi is just an SF Symbol with the opacities altered, the cell bars are actually a modified SF Symbol from the "bar chart" haha. Ill do as you said and replace those working assets!

twostraws commented 4 years ago

This is awesome work! Is this good to merge in?

pluddy commented 4 years ago

@twostraws I'm good if you are!