search

twostraws / ControlRoom

A macOS app to control the Xcode Simulator.
MIT License
5.77k stars 304 forks source link

Raise minimum window size #84

Closed apptekstudios closed 4 years ago

apptekstudios commented 4 years ago

Very simple PR here. The default window size (and also the minimum) was too small for the layout to work correctly. This raises that to the point that allows for proper layout.

Notably, the tab bar was not functional at small window sizes due to content overflow vertically. This seems to be due to Form on macOS using a VStack under the hood without any intrinsic scrolling ability.

Great little app, cheers for putting this together :)

twostraws commented 4 years ago

Thank you! What is the extra scheme doing? You didn't mention it.

apptekstudios commented 4 years ago

Sorry I didn’t realise the PR was from my master branch. That was an unrelated commit - it adds a scheme that builds in release config and launches without attaching a debugger. Purely for convenience when just using ControlRoom as opposed to developing it 👍🏻

I will remove that from this PR when I get a chance this afternoon. Happy to make a separate PR if you feel that’s a useful addition

apptekstudios commented 4 years ago

Have removed the unrelated commit 👍 (yay for temporary branches where force push isn't a forbidden fruit 😆)

twostraws commented 4 years ago

Thank you!