twostraws / Ignite

A static site generator for Swift developers.
MIT License
1.71k stars 94 forks source link

Swift 6 #133

Closed dl-alexandre closed 3 weeks ago

dl-alexandre commented 3 weeks ago

This making a few objects sendable including

The Version String is also preferably let + Updated for current v0.2.1

twostraws commented 3 weeks ago

Thank you – this looks great! Almost all the changes look good, but do we need to bump the Swift tools version number? It would restrict Ignite to folks using Swift 6 or later, which is far from everyone at this point.

dl-alexandre commented 3 weeks ago

Are you referencing those with Ignite as a module within existing bases? Isn't Swift 6 support module by module. Like a Swift 6 package functions within a Swift 5.9 base normally would. Can you defend someone using an older code-base, I'm just not understanding this wholly.

Of course though, if 5.9 is preferred, Sendable changes be implemented?

twostraws commented 3 weeks ago

I'm referring to someone who wants to build Ignite as a standalone project, who doesn't have Swift 6.

dl-alexandre commented 3 weeks ago

Understandable, Package.swift adjustments should be handled by you.

twostraws commented 3 weeks ago

Thank you! Once we actually need some Swift 6 features we can bump the version up. Until then, using an older swift-tools version should allow more people to use Ignite.