twostraws / Ignite

A static site generator for Swift developers.
MIT License
1.37k stars 59 forks source link

Feature: highlight active page in `NavigationBar` #49

Closed pd95 closed 6 days ago

pd95 commented 2 weeks ago

This Pull Request implements highlighting the currently active page in the NavigationBar as illustrated with the image below. It supports Links and DropDowns. The implementation relies on Bootstraps "active" CSS class for "nav-link" elements.

Current issues:

Hightlight-active-page

twostraws commented 1 week ago

This was something I had hoped to get into the initial release, but it just didn't make the cut because I ran out of time, so I have no problem merging it in now – I don't think it will cause any problems. You've also solved it exactly the right way given the current code structure, so I think we should get this merged in. Are you happy to move forward?

twostraws commented 6 days ago

Thank you, @PetrPrazak and @pd95! 🙌 All good to merge now?

pd95 commented 6 days ago

👍🏻 from my side.