search

twostraws / Inferno

Metal shaders for SwiftUI.
Other
2.46k stars 119 forks source link

Add Shift and Genie/Suck transition effect #20

Closed twodayslate closed 11 months ago

twodayslate commented 12 months ago

https://github.com/twostraws/Inferno/assets/1085707/bd653899-9ade-4c0a-89ee-5f5d2d448fdb

Shift from: https://nerdyak.tech/development/2023/06/16/distortionEffect-with-Metal-shaders-for-better-transitions.html

Genie shader from: https://www.shadertoy.com/view/flyfRt

Future work: parameterize functions for more customizability

twostraws commented 12 months ago

Hello! Thank you for this contribution! Can you confirm that these shaders are both licensed under the MIT license? It's important to remember that just because someone publishes source code online, it doesn't mean we have the right to use it freely.

twodayslate commented 12 months ago

I have sent @altaha-ansari an email to verify

twodayslate commented 12 months ago

I have already tagged @izakpavel on X, waiting for a response

Aayush9029 commented 12 months ago

image

Seems like it's MIT. Getting a verbal confirmation is always a good idea though.

twostraws commented 12 months ago

Ah! Yes, that license has now been added. I think getting permission as well is a very good idea, particularly for code that is already written in Metal.

twodayslate commented 12 months ago

From @altaha-ansari via email:

I hope this message finds you well. I'm delighted to see my work being utilized. I have added a License to my work on Shadertoy. I appreciate your interest in the code, and I'm reaching out to kindly request that you honor the MIT License terms associated with it.

As per the MIT License, you are free to use, modify, and distribute the code, but I would appreciate it if you could include the mentioned attribution in your project.

I have to rebase so can add a comment in the codebase and we can add his GitHub to the squash commit message as a thank you.

twostraws commented 12 months ago

Great! That's one down. You should also make sure and add the attribution in the README and LICENSE files. Thank you!