twostraws / Unwrap

Learn Swift interactively on your iPhone.
https://www.hackingwithswift.com
Other
2.3k stars 312 forks source link

Various small changes: comments, renamed methods and improved statements #159

Closed ramzesenok closed 4 years ago

ramzesenok commented 4 years ago

Improved the way comments are written:

Renamed few methods to more suitable names

Improved some statements

twostraws commented 4 years ago

Thank you for your contribution! It's generally better to submit several smaller pull requests that address specific issues, rather than submit one thing that does a lot at once. In this case, I don't wish to accept your change from triple to double comments, because I think it does more harm than good, but I can't accept the others until you with draw those.

It doesn't really matter whether triple-slashed comments are ignored or not; they are used consistently before things to document what they do. If some things are double-slashed and others tripled, it raises questions that really aren't interesting.

twostraws commented 4 years ago

Great – thank you!