twostraws / Unwrap

Learn Swift interactively on your iPhone.
https://www.hackingwithswift.com
Other
2.3k stars 312 forks source link

Wrapping user-facing strings in NSLocalizedString #204

Closed BasThomas closed 1 year ago

BasThomas commented 3 years ago

This pull request wraps user-facing strings in NSLocalizedString, so that they could be localized at a later point in time. Addresses #141.

To note:

twostraws commented 3 years ago

Hi Bas! Thanks for this. I'm a bit worried about the strings you mentioned that might affect functionality – this isn't a change I can easily merge in unless it gets some further verification.