search

twothicc / pe

0 stars 0 forks source link

No error messages for invalid data format on startup #7

Open twothicc opened 2 years ago

twothicc commented 2 years ago

I intentionally made a mistake in editing the data file by providing an invalid room number 101.01 for Bernice

image.png

image.png

I understand that the application is supposed to fail gracefully in the case of invalid data.

However, on startup, the app simply shows a blank screen without any error messages, which can definitely be confusing for users, especially those who do not have time to scan through the entire UG.

There should be an error message to inform users of invalid data format, hence I believe this is a feature flaw.

This is further made confusing by the fact that the service vendor data, which I did not intentionally change to be invalid, is still remaining.

image.png

nus-se-script commented 2 years ago

Team's Response

image.png

The modification of the JSON file should only be done by an experienced user who knows what they are doing, as we have stated clearly in the UG of the risk of corrupted data. As for why the vendor file was not affected, only the corrupted file will be replaced as stated in the UG.

In addition, I found out that it have been mentioned in the forums that it is not a requirement to modify the json, or furthermore modify the json with the wrong formatting.

image.png

image.png

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]