twothicc / pe

0 stars 0 forks source link

Able to add a vendor service cost of ridiculously high price #9

Open twothicc opened 2 years ago

twothicc commented 2 years ago

image.png

Prices such as these can be a misinput by the user and should have some sort of error message to warn against it.

nus-pe-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

large vendor service cost

when vendor has large service cost input, the display becomes different

Screenshot 2021-11-12 at 4.56.15 PM.png

example command: editvendor vid/333 c/21 c/9999999999999999999999999999


[original: nus-cs2103-AY2122S1/pe-interim#4839] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

Really unlikely to have a service cost this large, seems like deliberate sabotage.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The other issue claims that inputting very large inputs will change the display of the vendor cost.

However, my issue is that your feature allows for abnormally high service costs without providing the user any form of warning to guard against potential typos.

They are different issues. Therefore, I disagree with this duplicate status.


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

(Quoting the image) Lack of proper handling (either blocking or warning) for potentially invalid inputs can be considered a type.FeatureFlaw bug too.

My issue is that your feature allows for abnormally high service costs without providing the user any form of warning to guard against potential typos. I believe that my issue describes the lack of proper handling of vendor cost inputs, which fits the description of a FeatureFlaw as given by the website.

Imagine if you as a user added extra digits to your vendor cost input by accident and now the vendor cost is in the scale of tens of thousands. The application does not warn you of any form of misinput so you think that nothing is wrong. Then you proceed to charge your hotel guests this crazy sum of money. It would certainly lead to disastrous outcomes.

image.png

It should be expected and also the correct behavior for your application to have preventive measures against potentially invalid vendor cost inputs. However, your application lacks this sort of proper handling. Therefore, I believe that the issue should be accepted.


:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: image.png

(Quoting the image) Lack of proper handling (either blocking or warning) for potentially invalid inputs can be considered a type.FeatureFlaw bug too.

My issue is that your feature allows for abnormally high service costs without providing the user any form of warning to guard against potential typos. I believe that my issue describes the lack of proper handling of vendor cost inputs, which fits the description of a FeatureFlaw as given by the website.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]