twpayne / go-geom

Package geom implements efficient geometry types for geospatial applications.
BSD 2-Clause "Simplified" License
852 stars 105 forks source link

encoding/wkt: replace wkt parser with goyacc parser #197

Closed andyyang890 closed 3 years ago

andyyang890 commented 3 years ago

Fixes #151. Fixes #180.

twpayne commented 3 years ago

Thank you @andyyang890 - this is a fantastic contribution!

I just back from a few days away but will review in detail in the next couple of days.

twpayne commented 3 years ago

Thank you so much for this @andyyang890!

The code is excellent, and thank you in particularly for the detail in handling edge cases.

I'll patch up the lint failure in a separate PR.

andyyang890 commented 3 years ago

Sounds good, thanks for the detailed review!