twpayne / go-geom

Package geom implements efficient geometry types for geospatial applications.
BSD 2-Clause "Simplified" License
839 stars 104 forks source link

Support for numbers as `Feature.ID` #225

Closed DmitriyVTitov closed 1 year ago

DmitriyVTitov commented 1 year ago

This PR provides backward compatibility although with that requirement I think we cannot preserve ID type information after Marshal - Unmarshal (number would become string). So this is a kind of workaround. All tests pass and my own project works with this code.

twpayne commented 1 year ago

This is great - thank you.

There are a couple of minor tidy-ups needed, but I'll do these in a separate PR.

DmitriyVTitov commented 1 year ago

@twpayne Great! Could you create a new tag pls?

twpayne commented 1 year ago

Created v1.5.0.