twrecked / hass-aarlo

Asynchronous Arlo Component for Home Assistant
GNU Lesser General Public License v3.0
385 stars 78 forks source link

2FA Using imap with a custom port #481

Open BuggaHouse opened 3 years ago

BuggaHouse commented 3 years ago

Hi, I'm not using Gmail for my Arlo account and my provider is using another port.

Is it possible to expose a config for a custom port to match my email provider?

thanks

twrecked commented 3 years ago

I'll push a fix later this week. You'll be able to specify the port by putting it at the end of the host, something like this:

aarlo:
  ..
  tfa_host: yourimaphost.com:4444
twrecked commented 3 years ago

Should be fixed in 0.7.1.6. Let me know if it is.

kauthmbt commented 3 years ago

@twrecked Sorry for hi-jacking this but you should consider marking this as a breaking change: Even if you are using the standard IMAP port you are now forced to update your IMAP settings and include the port. Otherwise the add-on will not work anymore. Maybe it is by (coding) design but I learned it the hard way this morning ;)

twrecked commented 3 years ago

I thought I'd tested that, it should use the standard port unless you tell it otherwise.

I'll double check it.

edit: @kauthmbt It's working for me here. Are you sure it was an IMAP error and not a CloudFlareError, I'm seeing more and more of those arriving.

And if you are sure it's an IMAP error can you post some logs.

kauthmbt commented 3 years ago

@twrecked I will double-check again and if it was related to IMAP I will provide you with the logs.

BuggaHouse commented 3 years ago

Thanks for the quick fix and new version, I'll do proper tests this weekend.

BuggaHouse commented 3 years ago

Works for me, thank you again