twsaari / FeatureSequence

JBrowse plugin to view the sequence of features
GNU General Public License v3.0
7 stars 3 forks source link

This plugin has bugs in IE #7

Closed billzt closed 7 years ago

billzt commented 7 years ago

(1) Unless I load the plugin in the last plugin sets, the whole JBrowse failed in IE. The console says:

main.js (83,22) lacks ":"

(2) If I load the plugin in the last plugin sets, the JBrowse instance is OK in IE, however the plugin itself is still doesn't work in IE

twsaari commented 7 years ago

See the answer in #6, I think these errors are caused by the same line.

billzt commented 7 years ago

Well, after I fix it, it still doesn't work in IE. main.js (83,22):

 _prepareAndLaunch(track, feature){

        var self = this; //fix scoping problem with checkForOverlap within async call
twsaari commented 7 years ago

Ah I see, I bet it's just how the function is defined. Try this:

diff --git a/js/main.js b/js/main.js
index 7589f7e..f960aea 100644
--- a/js/main.js
+++ b/js/main.js
@@ -80,7 +80,7 @@ return declare( JBrowsePlugin,
      * @param {track (jbrowse object), feature (jbrowse object)}
      * @returns {  }
      */
-    _prepareAndLaunch(track, feature){
+    _prepareAndLaunch: function(track, feature){

         var self = this; //fix scoping problem with checkForOverlap within async call

Once again, I've also made changes to both branches.

billzt commented 7 years ago

Thanks, Now it works in IE