Create patches/tickets for our changes

[juniorz]

Group our changes by test file (or function), create a branch with all the changes and create a ticket on Tor trac.

[juniorz]

This is the list of test files we changed/created

$ git diff --stat upstream/master master -- src/test/test_*
 src/test/test_address.c                      |  132 ++-
 src/test/test_aes.c                          |   27 +
 src/test/test_buffers.c                      |    3 +-
 src/test/test_compat_libevent.c              |  214 +++++
 src/test/test_config.c                       | 2752 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 src/test/test_connection_edge_ap_handshake.c |  478 +++++++++++
 src/test/test_containers.c                   |    3 +-
 src/test/test_controller.c                   |    3 +-
 src/test/test_dir.c                          |  344 +++++++-
 src/test/test_dir_client_reached_eof.c       |   63 ++
 src/test/test_dir_handle_get.c               | 2539 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 src/test/test_entrynodes.c                   |   35 +-
 src/test/test_fast_handshake.c               |   24 +
 src/test/test_main.c                         | 1072 ++++++++++++++++++++++++
 src/test/test_options.c                      | 3408 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 src/test/test_procmon.c                      |   51 ++
 src/test/test_relay.c                        | 1030 ++++++++++++++++++++++-
 src/test/test_rendcache.c                    | 1178 ++++++++++++++++++++++++++
 src/test/test_sandbox.c                      |  154 ++++
 src/test/test_tortls.c                       | 2762 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 src/test/test_util_format.c                  |  197 +++++
 src/test/test_util_process.c                 |   67 ++
 22 files changed, 16487 insertions(+), 49 deletions(-)

We have patches for:

• [x] src/test/test_address.c #17074
• [x] src/test/test_aes.c
• [ ] src/test/test_buffers.c
• [x] src/test/test_compat_libevent.c #17075
• [x] src/test/test_config.c
  • #17077 - parse_port_config
  • #17020 - options_act
• [ ] src/test/test_connection_edge_ap_handshake.c
• [ ] src/test/test_containers.c
• [ ] src/test/test_controller.c
• [x] src/test/test_dir.c #17003
• [x] src/test/test_dir_handle_get.c #17004
• [ ] src/test/test_entrynodes.c
• [x] src/test/test_fast_handshake.c
• [x] src/test/test_main.c #17080
• [x] src/test/test_options.c #17076
• [x] src/test/test_procmon.c #17078
• [x] src/test/test_relay.c
• [x] src/test/test_rendcache.c #17079
• [x] src/test/test_sandbox.c #17081
• [x] src/test/test_tortls.c #17082
• [x] src/test/test_util_format.c #17084
• [x] src/test/test_util_process.c #17085

[tdruiva]

I think we shouldn't create an ticket to merge src/test/test_fast_handshake.c test (this is a silly test...)

[juniorz]

I suspect the aes_tests falls into the same category - look at these diffs:

• https://github.com/twstrike/tor_for_patching/compare/aes_tests
• https://github.com/twstrike/tor_for_patching/compare/fast_handshake_tests

Is it worth creating tickets for them?

On 9/15/15 2:52 PM, Tania Silva wrote:

I think we shouldn't create an ticket to merge src/test/test_fast_handshake.c test (this is a silly test...)

— Reply to this email directly or view it on GitHub https://github.com/twstrike/tor/issues/17#issuecomment-140517860.

Reinaldo de Souza Jr | Software Developer _Thought_Works Brasil

[olabini]

Well, the aes_tests was created to get coverage of aes.c up to 100%, and to have a place for other tests for the AES functionality. But it's probably not very high priority.