search

twtiger / gosecco

Go seccomp parser and compiler
GNU Lesser General Public License v3.0
53 stars 7 forks source link

We need support explicit loading of upper and lower argument halves #18

Closed olabini closed 8 years ago

olabini commented 8 years ago

I have a proposal for this ready, but it needs to be implemented. I'll do this after the new parser is merged.

olabini commented 8 years ago

This is supported in the parser and the AST now - the compiler still needs to do the right thing in general with all the argument stuff.

chelseakomlo commented 8 years ago

Ok, can we close this then?

yakiradixon commented 8 years ago

@olabini Could you point out where this is happening in the new parser? I'm missing it. :/

olabini commented 8 years ago

It's here: https://github.com/twtiger/gosecco/blob/master/parser/parser.go#L368 It's not obvious, but it's done in the place that sets the "Type" field of the Argument structure.

yakiradixon commented 8 years ago

Ah. Understood. Thanks.

chelseakomlo commented 8 years ago

@olabini I believe we need to adapt the parser to do similar things with constants, no? For #20

olabini commented 8 years ago

Nope.

olabini commented 8 years ago

The literal numbres will always be parsed as a 64bit number.

chelseakomlo commented 8 years ago

Right. Thanks :)

chelseakomlo commented 8 years ago

Ok. So we need to change our NumericLiteral value types to uint64?

olabini commented 8 years ago

Indeed.