search

twtiger / gosecco

Go seccomp parser and compiler
GNU Lesser General Public License v3.0
53 stars 7 forks source link

Fix all TODOs #35

Closed olabini closed 8 years ago

olabini commented 8 years ago

We have plenty of TODOs left in the code base - we should address all those.

chelseakomlo commented 8 years ago

A lot of these are around testing different parts of the API. Do you have any ideas on how to do this effectively? I was thinking to do something similar to go-seccomp-tester but if there is anything easier let me know. Not sure about writing tests for all of the API because of system calls.

olabini commented 8 years ago

We can generate a policy file on the fly, give it to Prepare, and make sure we get the expected output. Should be fairly simple.

chelseakomlo commented 8 years ago

One todo is to check that simplification errors come through. What kind of errors would we expect from the simplifier that the type checker wouldn't catch before?

chelseakomlo commented 8 years ago

Same question with the compiler- what errors would we expect here that wouldn't be caught by the type checker or parser.

olabini commented 8 years ago

Probably nothing - it might not be useful to test those.

chelseakomlo commented 8 years ago

Ok. The only TODO that remains is testing our output against the go-seccomp library