search

twuni / docker-registry.helm

Helm chart for a Docker registry. Successor to stable/docker-registry chart.
Apache License 2.0
309 stars 146 forks source link

Adding Deployment Annotations #106

Closed ChevronTango closed 6 months ago

ChevronTango commented 1 year ago

Closes #86

This adds the ability for users to specify annotations on the deployment.

joshsizer commented 6 months ago

@ChevronTango Could you recommit these changes with signed commits?

This comment has some resources to help with that if you need it: https://github.com/twuni/docker-registry.helm/pull/93#issuecomment-1979504730

vyas-n commented 6 months ago

Looks good to me, just needs signed commits before it can be merged 👍🏽

ChevronTango commented 6 months ago

Just pushed up a signed commit using Sigstore, however GitHub doesn't formally support those signatures yet, despite them being valid and secure. Hopefully that doesn't prevent the merge going ahead. If it does I'll resign using a GPG key.

joshsizer commented 6 months ago

@ChevronTango Unfortunately GitHub is still saying that the commits need to be signed. Could you go ahead and commit them again with GPG/SSH?

ChevronTango commented 6 months ago

@joshsizer that should be all ready to go now

joshsizer commented 6 months ago

@joshsizer that should be all ready to go now

Thank you!