Wkbrd security patch - Githubissues

twuni / docker-registry.helm

Helm chart for a Docker registry. Successor to stable/docker-registry chart.

Apache License 2.0

309 stars 146 forks source link

Wkbrd security patch #129

Closed wkbrd closed 4 months ago

wkbrd commented 4 months ago

This branch adds additional securityContext controls to align with those available from the Bitnami Helm charts.

This also renames the securityContext value to podSecurityContext in alignment with the Bitnami values.

Added Apache license details from Bitnami due to the README.md borrowing text from the Bitnami README.md file

canterberry commented 4 months ago

Thanks @wkbrd! Always good to see some security-minded folks having a look and seeking to improve things.

I just took a review pass and left some feedback above. The gist: the new default values look good to me, but I'd like to see some diligence on compatibility so we don't inadvertently break things for folks when they upgrade this chart.

wkbrd commented 4 months ago

Hi @canterberry , I think this addresses the changes you requested. The only changed file is now values.yaml.