search

twuni / docker-registry.helm

Helm chart for a Docker registry. Successor to stable/docker-registry chart.
Apache License 2.0
309 stars 146 forks source link

add the ability to specify labels for the registry service #131

Closed laverya closed 3 months ago

laverya commented 3 months ago

Labels can currently be specified for the ingress, servicemonitor, prometheusRules, and the registry pods themselves.

This expands that to the registry service, so that we can exclude it from velero snapshots and restores. (why? because we create this with a static IP address, and velero does not restore static IP addresses)

I would also be happy to expand this pattern to all of the other resources in the repository - the configmap, cronjob, deployment, hpa, pdb, pvc, secret and serviceaccount objects.

laverya commented 3 months ago

Is this something that you'd be interested in @vyas-n ?

laverya commented 3 months ago

I've pushed again with a signed-off commit - thanks for taking a look!

laverya commented 3 months ago

Let me know if you'd like me to expand this to the other resources as well!

vyas-n commented 3 months ago

Hey @laverya,

Good idea to extend this to other resources as well, let's start with getting this in and other resources can be covered in another PR.

Looks like your recent force-push is still not signed: https://github.com/twuni/docker-registry.helm/pull/131/commits

If you need some help signing your commits, here's a good doc from GitHub that's helped me get my commits signed:

laverya commented 3 months ago

OH you meant cryptographically signed and not committed with -s!

Can do

laverya commented 3 months ago

Pushed with a GPG-signed commit now

vyas-n commented 3 months ago

Thanks, @laverya!

If you want to coordinate with future changes, then feel free to open a Discussion with a msg including @vyas-n in it, and we can discuss some change ideas.

You can also continue opening PRs, and I'll do my best to review them in a timely manner.