search

twuni / docker-registry.helm

Helm chart for a Docker registry. Successor to stable/docker-registry chart.
Apache License 2.0
309 stars 146 forks source link

nosniff in config.yml #94

Open gleupold opened 1 year ago

gleupold commented 1 year ago

Hi,

while investigating, delete is "unsupported" although we set:

delete:
  enabled: true

we noticed in: /etc/docker/registry/config.yml

health:
  storagedriver:
    enabled: true
    interval: 10s
    threshold: 3
http:
  addr: :5000
  debug:
    addr: :5001
    prometheus:
      enabled: true
      path: /metrics
  headers:
    X-Content-Type-Options:
    - nosniff
log:
  fields:
    service: registry
storage:
  cache:
    blobdescriptor: inmemory
  delete:
    enabled: true
  maintenance:
    uploadpurging:
      age: 168h
      dryrun: false
      enabled: true
      interval: 24h
version: 0.1

that nosniff looks wrong? Shouldnt the http headers look like this: headers: X-Content-Type-Options: [nosniff] We expect the "toYaml" in https://github.com/twuni/docker-registry.helm/blob/405346f80e6e33860e4cc57488d9b308c4c16e50/templates/configmap.yaml#L13 to issue that but dont know how to fix it. Or does it work as expected?

Best regards