tx00100xt / SeriousSamClassic-VK

Open source game engine version developed by Croteam for Serious Sam Classic with Vulkan support (Windows, Linux, FreeBSD, OpenBSD, macOS, Raspberry Pi OS). Based on https://github.com/sultim-t/Serious-Engine-Vk and linux port https://github.com/icculus/Serious-Engine
GNU General Public License v2.0
101 stars 12 forks source link

Some effects are missing: Thunders, sun flares, SFX sounds #15

Open Sol1vaN opened 1 year ago

Sol1vaN commented 1 year ago

Hi again,

I've noticed that are some visual effects and sound effects are missing in your port. I've recorded 2 videos showing that I say.

Until now this is that I've founded:

  1. No thunders
  2. No sun flares
  3. No sound FX for thunders

I'm concern if other stuff are missing. But if I found another I'll inform you.

Here's the videos: Serious Sam FE 1.05 Vanilla OGL: https://youtu.be/zi6yGRxA6fY Serious Sam FE 1.05 VK Port 1.10.4: https://youtu.be/4tW1u-RFaZg

tx00100xt commented 1 year ago

Hello. On points 1 and 3, yes, indeed there is no thunder, lightning and lightning flashes. Haven't played the original in a while so I didn't pay attention to it. It won't be difficult to fix it.

Point 2 (sun flare) - this is more difficult. This is a lens flare and the vulcan render itself is responsible for their correct display. The render code was written by Sultim Tsyrendashiev https://github.com/sultim-t https://github.com/sultim-t/Serious-Engine-Vk and he did not complete the lens flare. They have bugs and have therefore been disabled. (Lens flares pass through walls) I just ported render vulcan from windows to linux. This is what the bugs look like: Снимок экрана в 2023-02-02 23-27-47 Снимок экрана в 2023-02-02 23-28-16

If you need a lens flare, then you can change the graphic API to OpenGL in the video menu. On OpenGL Lens Flare works correctly. When he fixes these bugs, I will definitely add lens flare support to the port.

On points 1 and 3, I think to make a correction in the coming days. Thanks for the report.

tx00100xt commented 1 year ago

On points 1 and 3, Ready https://github.com/tx00100xt/SeriousSamClassic-VK/commit/d054df53eff87610c5989e5c10dee1e15b1fdf79

Now thunder, lightning and lightning flashes is works. Release for Windows updated: https://github.com/tx00100xt/SeriousSamClassic-VK/releases/download/v1.10.4/SeriousSamClassicVk-1.10.4-win32-bin.zip https://github.com/tx00100xt/SeriousSamClassic-VK/releases/download/v1.10.4/SeriousSamClassicVk-1.10.4-win64-bin.zip For Linux and FreeBSD I will update later.

I think the issue should be left open - until the lens flare is fixed.

Sol1vaN commented 1 year ago

thanks for the fix! interesting info too!

i hope some day Sultim fix the sun flare rendering problem.