Modular - Githubissues

txa / cftlfp

0 stars 0 forks source link

Modular #10

Closed jacobneu closed 3 months ago

jacobneu commented 3 months ago

Renamed notes to CftLFP
Split file into individual chapters
Changed from article to book, renamed sections to chapters, subsections to sections, etc.
Moved macros into separate file

Closes #4 Closes #19

jacobneu commented 3 months ago

https://github.com/txa/cftlfp/issues/4#issuecomment-2232761746

jacobneu commented 3 months ago

#4 (comment)

Should this be a separate chapter from preliminaries? As it is, preliminaries is rather short, so it would make sense to rename the first chapter to 'Introduction', and have preliminaries as a section. The content of preliminaries would fit in well with the content described in #17, as far as I can tell.

txa commented 3 months ago

#4 (comment)

Should this be a separate chapter from preliminaries? As it is, preliminaries is rather short, so it would make sense to rename the first chapter to 'Introduction', and have preliminaries as a section. The content of preliminaries would fit in well with the content described in #17, as far as I can tell.

Ok let's do that then.

txa commented 3 months ago

I still get an error if i just say make - is this intended?

txa commented 3 months ago

Ok, what is our policy? Shall I merge or leave it to you?

jacobneu commented 3 months ago

Ok, what is our policy? Shall I merge or leave it to you?

I'll change the first chapter to 'Introduction' and then merge. In the future, I think we can just have the policy of merging it when both of us have had the chance to look at it (i.e. one of us creates the PR, the other approves the changes, and then the creator of the PR merges, like we've done here)