search

txbm / angular-chartjs

Directive set for the ChartJS library. Supports data bindings and attribute-level specification for chart specific options. The only Angular ChartJS module that supports ALL chart options as HTML5 attributes :)
MIT License
146 stars 37 forks source link

Bug #9 Canvas height leaking when autofit=true #12

Closed ivanhtp closed 10 years ago

ivanhtp commented 10 years ago

Fixes bug #9 caused when autofit=true and the parent div height is set with percentual dimensions. Commenting the line above prevents the canvas height to be incremented and the height gets same value of the width. In my case, solved the problem (didn't tested a lot).

txbm commented 10 years ago

Will test this more locally before I merge. My only concern is that it may break another feature.

ivanhtp commented 10 years ago

Yeah. Its possible! Worked for me because I only use pie and doughnut charts (they are squared with height = width). I really could break bar charts.

On Thu, Jul 17, 2014 at 4:31 PM, Peter M. Elias notifications@github.com wrote:

Will test this more locally before I merge. My only concern is that it may break another feature.

— Reply to this email directly or view it on GitHub https://github.com/petermelias/angular-chartjs/pull/12#issuecomment-49353031 .

txbm commented 10 years ago

Not to worry, once I push the next round of updates in sync with ChartJS this and other issues will all be fixed.