search

txbm / angular-chartjs

Directive set for the ChartJS library. Supports data bindings and attribute-level specification for chart specific options. The only Angular ChartJS module that supports ALL chart options as HTML5 attributes :)
MIT License
146 stars 37 forks source link

Don't work with IE8 + excanvas polyfill. #6

Closed ivanhtp closed 8 years ago

ivanhtp commented 10 years ago

The chartJS documentation, supports IE8 if you use excanvas.js. So I imported it and in addition, I used your directive as attribute instead of element (

For some reason, this directive dont work in ie8, even with the polyfill. In ie8 console we got TypeError: Object doesn't support this property or method<:canvas autofit="false options="barOptions" dataset="report.barData" cjs-bar

txbm commented 10 years ago

I'd need to see a JsBin or something like that to begin any kind of real debugging for this one...

My gut says this is soon to be irrelevant as the ChartJS library is finally being bumped up to it's 1.0beta release and there have been sweeping API and internal changes that may have solved this issue. It's not likely a problem with this plugin.

I'll be updating this plugin accordingly with the new ChartJS updates and I'll keep an eye out for this problem in any case.

ivanhtp commented 10 years ago

Thanks for the reply,

I thought it was a plugin problem, cause the Chartjs purely (out of an angular environment, without any binding) works well with excanvas. But I'll wait the new releases.

On Fri, Jul 11, 2014 at 6:37 PM, Peter M. Elias notifications@github.com wrote:

I'd need to see a JsBin or something like that to begin any kind of real debugging for this one...

My gut says this is soon to be irrelevant as the ChartJS library is finally being bumped up to it's 1.0beta release and there have been sweeping API and internal changes that may have solved this issue. It's not likely a problem with this plugin.

I'll be updating this plugin accordingly with the new ChartJS updates and I'll keep an eye out for this problem in any case.

— Reply to this email directly or view it on GitHub https://github.com/petermelias/angular-chartjs/issues/6#issuecomment-48785965 .

txbm commented 10 years ago

Just setup Plunkr or a Jsbin with the code that causes the error-- I'll take a look.

txbm commented 10 years ago

Backburnering this unless somebody can reproduce and provide a Plunkr for it.

robfarmer-ai commented 9 years ago

I'm having this same issue in IE8. Trying to create a Plunkr, JSBin or similar but having issues with them in IE8 as well. Would a zip file with an example work?

txbm commented 9 years ago

@robfarmer-ai yeah sure email it to me

robfarmer-ai commented 9 years ago

@petermelias Any luck with this issue?

jfeigel commented 9 years ago

@petermelias I fixed this issue for a project I am working on and fixed the source locally. I have created the following pull request: https://github.com/petermelias/angular-chartjs/pull/36

txbm commented 9 years ago

Pull request works On Dec 17, 2014 9:02 AM, "James" notifications@github.com wrote:

@petermelias https://github.com/petermelias I fixed this issue for a project I am working on and fixed the source locally. How would you like me to get it to you?

— Reply to this email directly or view it on GitHub https://github.com/petermelias/angular-chartjs/issues/6#issuecomment-67334110 .