search

txchen / feplay

Frontend Play
MIT License
219 stars 41 forks source link

Post to tastejs/todomvc #4

Closed tipiirai closed 9 years ago

tipiirai commented 9 years ago

I think this Riot 2.0 example should be posted to the official Todo MVC repository. They are not too open to new suggestions so I suggest to read the contributing document very closely.

Here is a very interesting discussion why we were rejected last time.

Willing to take a shot?

txchen commented 9 years ago

@tipiirai Yeah, I'd like to have a try.

However before that, can I ask you to do a code review? Basically I'd like to ensure my code is following a correct or suggested style of writing riotjs.

txchen commented 9 years ago

@tipiirai FYI, I have started this task. https://github.com/txchen/todomvc/commit/0e4a6aea06c337a7cb38faa8136d5716d692ecf5

Currently the browser tests are not passing, I will investigate. Once it is ready, I will send the PR.

In the mean while, would you please have a review on this?

txchen commented 9 years ago

Blocked by browser test. Please take a look at this and help, thanks! https://github.com/muut/riotjs/issues/413

txchen commented 9 years ago

It is merged into todomvc.

tipiirai commented 9 years ago

Awesome.

Thank you for the hard push on this! Looks like we're under the "labs" section on the home page: http://todomvc.com/