txie-93 / cgcnn

Crystal graph convolutional neural networks for predicting material properties.
MIT License
651 stars 309 forks source link

[RFC] Zero padding can be removed using torch-scatter #16

Closed CompRhys closed 4 years ago

CompRhys commented 4 years ago

I have updated as little as possible of the code in order to remove zero-padding from the model. This means that the code can now consider more than a fixed number of neighbours without introducing new 'zero padding' atoms.

Such 'zero padding' atoms are potentially a problem as the use of affine transformations means that the 'zero padding' atoms affect the final result as the bias vectors will introduce no zero features vectors for these atoms.

The _torchscatter library has been used to perform the necessary scatter operations.

The pre-trained models have not been re-trained.

feel free to make changes to this PR.

CompRhys commented 4 years ago

Closed in favour of #18.