search

txm676 / gambin

The gambin R package
3 stars 3 forks source link

Merging Colin's changes with main repo #8

Closed txm676 closed 7 years ago

txm676 commented 7 years ago

Michael has transferred the main repo to me, and it is quite far behind your version

mkborregaard commented 7 years ago

LGTM. You guys have really moved this along!

mkborregaard commented 7 years ago

It looks a bit strange @txm676 that you're doing the PR from Colin to your fork, instead of @csgillespie opening this, but I guess that works as well :-)

txm676 commented 7 years ago

@mkborregaard this is less to do with efficiency and more to do with my very poor github knowledge :(

csgillespie commented 7 years ago

@txm676 Should be good to merge.

BTW, you should sign up for travis and codv (see the badges in the README)

txm676 commented 7 years ago

@csgillespie great, thanks

I'm signed up for travis - seems to be checking it all now

mkborregaard commented 7 years ago

Looks like you gotta add rmarkdown install to your travis commands.

txm676 commented 7 years ago

I've tried to add it but having some issues, will try again tomorrow.

On 13 June 2017 at 17:33, Michael Krabbe Borregaard < notifications@github.com> wrote:

Looks like you gotta add rmarkdown install to your travis commands.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/txm676/gambin/pull/8#issuecomment-308174524, or mute the thread https://github.com/notifications/unsubscribe-auth/AXV68m78YK7DtSGccrdQoWqoeHgcL4Uqks5sDrnRgaJpZM4N3Ym5 .