search

txnimc / BalancedFlight

MIT License
1 stars 6 forks source link

Option to apply Slow Falling on disable flight #21

Closed jstnf closed 9 months ago

jstnf commented 1 year ago

Currently, there is a bug that permanently applies the Slow Falling effect in certain situations with other mods (see #16)

Therefore, I've added a configuration option so server owners can disable the Slow Falling effect added on every tick. The mod will still disable flight, but it will not inflict the Slow Falling potion effect.

Tested on my own server running FTB Unstable 1.20 v1.5.0

SrRapero720 commented 1 year ago

1: any PR should be done in a default branch. 2: an option to disable slow falling can be good, but isn't a solution for incompatibility with other mods.

this my be solved adding a player storage for already non flying players, player capabilities or a extra code check for other mods (not good to do).

when i got time i can do a PR with a fix.

SrRapero720 commented 1 year ago

btw, looks like the mod was forgotten by the author

jstnf commented 1 year ago

1: any PR should be done in a default branch. 2: an option to disable slow falling can be good, but isn't a solution for incompatibility with other mods.

this my be solved adding a player storage for already non flying players, player capabilities or a extra code check for other mods (not good to do).

when i got time i can do a PR with a fix.

Yea figures, got my players on this small patch to rectify their issues for now. Not a solution at all, of course, but no time on my end to make a comprehensive fix like you've described.

sprocketaudio commented 8 months ago

is there anyway this patch will get released officially like on curse? Its really annoying to ahve this and imo makes the mod almost unusable. I am on 1.19.2 btw