search

txnimc / ImmersiveLanterns

MIT License
1 stars 2 forks source link

[Feature request] Lantern brightness config option #7

Open 533kr opened 1 month ago

533kr commented 1 month ago

Not sure how much of a pain in the ass this would be, but would it be possible to include some sort of config option for lantern brightness? I'm really loving the visual swinging lantern effect, but in my game the light is VERY dim, maybe half of what a handheld lantern puts out.

nthxny commented 1 month ago

it shouldn't actually be dim -- it should be giving off 15 light level. I do want to make that configurable though, that's easy to do.

533kr commented 1 month ago

Sorry for the delay--I grabbed a video showing what I'm seeing when I equip one versus the normal held brightness. There's probably some other mod causing problems, I have a huge list, but I figured I ought to let you know!

https://github.com/user-attachments/assets/0ec2f6aa-7b48-471f-a94b-95319fbc9f50

It's definitely working, the lantern shows up and has nice physics, it DOES put out light...just very dimly.

nthxny commented 4 weeks ago

it does look like you have some other mod affecting lantern brightness, since it appears to be flickering

FaNt4zMa commented 3 weeks ago

Side note slightly unrelated: The soul lantern emits the same brightness as the regular lantern when equipped, which is not the case when holding it.

533kr commented 3 weeks ago

The flickering is a shader setting, it shouldn't and generally doesn't effect the actual brightness of objects in this way. It could definitely be interacting strangely with this mod specifically, but it's Complementary Unbound + Euphoria patches (so not a super-niche shader selection) and so far this mod is the only wearable lantern mod that's had this issue. Other mods that add belt lanterns via trinkets slots retain the same brightness as when they're held.