txnimc / SodiumDynamicLights

MIT License
9 stars 2 forks source link

[BUG] Crash on start-up caused by Spell Engine and Simply Swords [Fabric 1.20.1/0.16.5] #9

Closed pokesmells closed 1 month ago

pokesmells commented 1 month ago

When loading the game, it crashes on startup https://mclo.gs/Hh0lrgR

pokesmells commented 1 month ago

When loading the game, it crashes on startup https://mclo.gs/Hh0lrgR

https://mclo.gs/0N0B1Jv - latest.log

memphismc commented 1 month ago

same

crash-2024-09-14_21.13.57-client.txt

ZsoltMolnarrr commented 1 month ago

I am unable to fix this problem without a documentation available.

LambDynamicLights used to have a wiki describing how to use their APIs.

ZsoltMolnarrr commented 1 month ago

Moreover, the implementation of this distribution is incorrect.

It uses the old entrypoint, defined by of LambDynamicLights, for example:

    "dynamiclights": [
      "net.spell_engine.client.compatibility.DynamicLightsCompatibility"
    ]

While expecting new package names to be used.

To handle breaking changes in a more compatible manner, it is strongly recommended for this project to rename its entrypoint, to something unique. (such as sodium_dynamic_lights)

The current state of this project makes it impossible to support both LambDynamicLights and SodiumDynamicLights, forcing the code to choose.

nthxny commented 1 month ago

I've renamed the entrypoint back to the lambdynlights namespace, so this should be resolved. Tested and working with Spell Engine and other mods using the API

memphismc commented 1 month ago

crash-2024-09-22_20.40.28-client.txt

still crashes on startup, using latest version

pokesmells commented 1 month ago

I've renamed the entrypoint back to the lambdynlights namespace, so this should be resolved. Tested and working with Spell Engine and other mods using the API

Still Crashes on start-up

https://mclo.gs/D3lJnsk

nthxny commented 1 month ago

It seems I had only tested on Fabric 1.21, which doesn't even have the original LambDynLights yet. So nothing was happening and nothing was crashing lol. Should be properly fixed now in latest update

memphismc commented 1 month ago

yeah its fixed 👍