search

txnimc / Spice-of-Life-Apple-Pie

GNU Lesser General Public License v2.1
3 stars 4 forks source link

[Bug] Bonuses are applied on top of themselves after server restarts #10

Open grundyboy34 opened 1 year ago

grundyboy34 commented 1 year ago

Description Note this on a dedicated server. I've changed all bonuses to be +2 health for every 10 diversity, which has led me to notice that after a server restart, players get their current bonus reapplied on top of itself (so someone with +2 is now +4, then after a second restart, +6). This resets back to the bonus it should be if they die however.

To Reproduce 1) Set bonuses to +2 health per 10 diversity, up to 100 diversity. 2) Get at least 10 diversity, to get an extra heart of health. 3) Restart the dedicated server 4) Login, notice that you now have 2 extra hearts 5) Restart the server and login again, notice that you now have 3 extra hearts 6) Die, notice that you go back to only one extra heart

Mod version and Forge version solappliepie: 1.20.1-2.3.0 Forge: 47.1.3

Inf0214 commented 7 months ago

Can confirm, Im up to 21 extra hearths in dawncraft... getting ridiculous :D image

It only happens when the server crashes, regular restart doesnt seem to do it. solapplepie-1.18.2-1.0.4.jar forge : 40.2.17

Inf0214 commented 7 months ago

Description Note this on a dedicated server. I've changed all bonuses to be +2 health for every 10 diversity, which has led me to notice that after a server restart, players get their current bonus reapplied on top of itself (so someone with +2 is now +4, then after a second restart, +6). This resets back to the bonus it should be if they die however.

To Reproduce

  1. Set bonuses to +2 health per 10 diversity, up to 100 diversity.
  2. Get at least 10 diversity, to get an extra heart of health.
  3. Restart the dedicated server
  4. Login, notice that you now have 2 extra hearts
  5. Restart the server and login again, notice that you now have 3 extra hearts
  6. Die, notice that you go back to only one extra heart

Mod version and Forge version solappliepie: 1.20.1-2.3.0 Forge: 47.1.3

Could you try: /solapplepie sync I dont have access to the command on the server I play on. Running the command after reboot could be a workaround for now.

StonedGoat commented 2 months ago

bumping this because i accidentally duplicate reported the same thing oopsie :(

also the command in question doesn't appear to fix the issue over here.