search

tyagi-iiitv / infographics_generation

9 stars 1 forks source link

Issue 6 #7

Closed OrcinusOcean closed 4 years ago

OrcinusOcean commented 4 years ago

You can remove the text by click the button above the text. When your cursor move above the text, the button will be shown. I copied node_modules to my branch, so that you don't need to compare the automatically generated stuff. Just ignore the another pull request. Issue 6 branch inherit all the changes form master.

tyagi-iiitv commented 4 years ago

Hi Yulin, thanks for the PR. Actually, node modules are generated with the 'yarn install' command when we try to run the React App for the very first time. So, if the package.json file is configured correctly, then generating node modules shouldn't be a problem. Sometimes though, node modules are not correctly configured which results in runtime errors. In that case, just deleting the node modules folder and running 'yarn install' again resolves the issue. So, I would still prefer not adding node modules to the github repo.

OrcinusOcean commented 4 years ago

I deleted nodes modules.