Getting information for missing user IDs result in unclosed client sessions

tybug / ossapi

The definitive python wrapper for the osu! api.

https://tybug.github.io/ossapi/

GNU Affero General Public License v3.0

82 stars 18 forks source link

Closed cocoon333 closed 1 year ago

cocoon333 commented 1 year ago

Version 3.1.5

tybug commented 1 year ago

There are two issues here:

aiohttp's urls are URL objects instead of strings, so unqoute fails and doesn't give the correct error message.
spurious unclosed client session warnings on error. These are warnings and can be safely ignored, but I've improved our management of the session lifetime to fix this.

I've fixed both issues in f9cbfce.