search

tybug / ossapi

The definitive python wrapper for the osu! api.
https://tybug.github.io/ossapi/
GNU Affero General Public License v3.0
82 stars 18 forks source link

Error on scores with xK mod (mania) #67

Closed yanda-dy closed 1 year ago

yanda-dy commented 1 year ago

The short names in int_to_mod (mod.py) should probably be xK instead of Kx

Example:

score = api.score(score_id=468410699, mode="mania")

returns

- ValueError: Invalid mod string (no matching mod found for 4K)

(also, bumping the Event -> _Event change in #66)

tybug commented 1 year ago

Changing Mod has potentially wide-reaching implications, including for circleguard and circlecore, so I'm always cautious of doing so. However, changing the short name here seems harmless enough, and moreover is correct according to osu-web acronyms (as this issue shows).

I've fixed this in https://github.com/circleguard/ossapi/commit/f295862079043c8e9b1a46040ed99028b014ff9d.