search

tybug / ossapi

The definitive python wrapper for the osu! api.
https://tybug.github.io/ossapi/
GNU Affero General Public License v3.0
82 stars 18 forks source link

Add undocumented `CountryStatistics` model for `Rankings` #74

Closed ItsMestro closed 1 year ago

ItsMestro commented 1 year ago

A list of CountryStatistics is returned when getting rankings with RankingType.COUNTRY

I don't know if implementation should be different to not make type hints awful but this at least allows for country rankings to be fetched.

ItsMestro commented 1 year ago

Realized I didn't test this properly and does not work in its current form because the type instantiation doesn't like unions. But that's where my knowledge of this project ends.

tybug commented 1 year ago

I've touched things up - thanks for the contribution!