search

tybug / ossapi

The definitive python wrapper for the osu! api.
https://tybug.github.io/ossapi/
GNU Affero General Public License v3.0
82 stars 18 forks source link

Score.ended_at should be not be Optional[] #86

Closed Syriiin closed 1 day ago

Syriiin commented 2 days ago

According to the x-api-version >= 20220705 docs and a quick check of the table schema it seems Score.ended_at should be simply a Datetime.

Haven't done a thorough check of osu-web so I might be mistaken, but it also intuitively makes sense, since all scores have an associated date.

tybug commented 1 day ago

This makes me a bit nervous, because the api docs have been consistently wrong about the nullability of attributes, and I tend to just ignore them in favor of empirical testing nowadays. That said, the migration is strong evidence for this. I think it's likely I was overzealous for this particular type. Thanks!