search

tybug / snitchvisbot

A snitch visualization discord bot for civ-style minecraft servers
GNU Affero General Public License v3.0
7 stars 3 forks source link

add docker support #3

Closed Huskydog9988 closed 2 years ago

Huskydog9988 commented 2 years ago

Support for deploying with docker. Requires #2 so the env vars can be used to configure the bot.

This pr can be changed so you have to use the config.py file directly, (and not use env vars,) but I highly advise against it.

tybug commented 2 years ago

not sure about this. I'm not going to use docker, so I'm uneasy about committing a feature which I don't use and could easily become broken in the future without me knowing. Adds burden to me as a maintainer when people then come and complain something I claim to support is broken.

Huskydog9988 commented 2 years ago

With this setup, very little should break it, but you correct you would be burdened by this. You could always say its "not a supported option", but does exist so you "don't have to make your own." kinda thing.

tybug commented 2 years ago

fair enough. I've added a pretty strongly worded disclaimer to the readme.