search

tychedelia / kafka-protocol-rs

Rust Kafka protocol
Apache License 2.0
63 stars 23 forks source link

update pinned rust + fix clippy lints #92

Closed rukai closed 1 month ago

rukai commented 1 month ago

Update the pinned rust version and fix clippy lints. Turns out the feature for snappy compression was broken, the name of the feature was different to the name used in the cfgs and rust 1.76 didnt pick this up yet.

I set the feature name to "snappy" to match the name of the compression format rather than the name "snap" which is the rust crate that implements snappy, since the choice of crate is an implementation detail.

AFAIK this project has no MSRV requirements, so the toolchain is not set to an old version to ensure an MSRV, if desired I can leave it a few versions behind though.

tychedelia commented 1 month ago

if desired I can leave it a few versions behind though.

I think it's fine for now, let's revisit when (if) we decide to go 1.0.