tychedelia / kafka-protocol-rs

Rust Kafka protocol
Apache License 2.0
63 stars 23 forks source link

[Breaking change] remove "Key" suffix from ApiKey variants #97

Open rukai opened 5 days ago

rukai commented 5 days ago

Similar change to https://github.com/tychedelia/kafka-protocol-rs/pull/61

The "Key" suffix is redundant since the variants are usually written out as ApiKey::ProduceKey.

Additionally its common to log a key type by doing something like log!("failed to parse message type {api_key:?}"), in this case including the Key is confusing because it seems like Key is part of the message name.