tycooon / memery

A gem for memoization in Ruby
MIT License
177 stars 13 forks source link

Add `.memoized?` method #17

Closed AlexWayfer closed 5 years ago

AlexWayfer commented 5 years ago

To check (externally) if method memoized or not.

tycooon commented 5 years ago

Please add new method to the Readme.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 59


Changes Missing Coverage Covered Lines Changed/Added Lines %
spec/memery_spec.rb 35 39 89.74%
<!-- Total: 37 41 90.24% -->
Totals Coverage Status
Change from base Build 54: -1.7%
Covered Lines: 903
Relevant Lines: 919

💛 - Coveralls
AlexWayfer commented 5 years ago

Please add new method to the Readme.

Yes, done.

tycooon commented 5 years ago

Please check the coverage, it looks like there is some dead code in specs: https://coveralls.io/builds/25906116

AlexWayfer commented 5 years ago

Please check the coverage, it looks like there is some dead code in specs

I think we should filter /spec from coverage, but OK, I've removed the body of unused method.

tycooon commented 5 years ago

Please check the coverage, it looks like there is some dead code in specs

I think we should filter /spec from coverage, but OK, I've removed the body of unused method.

It still shows coverage decrease. Why do we need the code that is never called in specs? 🤔

AlexWayfer commented 5 years ago

It still shows coverage decrease. Why do we need the code that is never called in specs? thinking

OK, another one, I'm sorry. Removed.