search

tycrek / ass

The simple self-hosted ShareX server
ISC License
646 stars 50 forks source link

[FEATURE] Cloudflare R2 (S3) Support #155

Closed Permanently closed 1 year ago

Permanently commented 2 years ago

Description

This is pretty much a ticket to check whether Cloudflare R2 is supported. Cloudflare says it's somewhat compatible, depending on what's used. Documentation & compatibility can be viewed here.

tycrek commented 1 year ago

I looked into this for a bit and tried a bunch of different methods but couldn't get the aws-sdk library to work with it. Perhaps someone else would have better luck. (Edit: and I'm not willing to switch to a new library just for one S3 host. If the demand is there, fork the project (edit: that wasn't supposed to sounds mean lol))

I also looked into the Workers method... yikes. Far more work effort than I feel like most hosts would be willing to put in. At that point you're basically just writing two file upload servers.

So in summary: R2 is unsupported for now. If Cloudflare improves their implementation of S3 in the future, this may change.

LeagueRaINi commented 9 months ago

Any updates on this? r2 s3 compat seems good enough now, i had to edit getS3url to serve from a different domain than the private s3 endpoint and have that running fine atm

as to why i had to edit the src, i'm pretty new to r2 so i dont know if there is a different way i'm not aware of but it seems like r2 has a private api endpoint for api calls and then u set a different domain for serving (that one cannot interact with the api from my testing) which is why i had to edit getS3url, that domain also doesnt seem to support any of the path styles you are using (eg bucket.domain and domain/bucket) probably because its directly attached to the bucket, its just the domain, not sure how that would be integrated (if u even plan to), thats how i did it rn

https://github.com/LeagueRaINi/ass/commit/e621f4fb38b329e93d495f9129b89bc307df9944

Permanently commented 9 months ago

I've been using Cloudflare R2 with Mastodon, which is mainly S3-oriented. I've had no issues with it whatsoever.

But, it's not my call to say whether it's safe to use or not. That's just my experience.

tycrek commented 9 months ago

I'm more inclined to support it now, though it would be a feature for 0.15.0 (see PR #220)