tydanielson / bgcalculator

Tool for researching the best stocks
https://apps.valuvesting.com
MIT License
2 stars 1 forks source link

App Calculation Errors #25

Closed drewengquist closed 7 years ago

drewengquist commented 7 years ago

I spot checked the ones you sent over last night - I really like PVH by the way. BEN looks right on in terms of BG score. PVH - I believe this one should be 6/7, however the calculator is displaying 5.5/7. It should lose a half point for LT-Debt coverage and a half point for PE-PB aggregate. (PB is too high, but PE*PB<22.5)

NOV - This one should be 3/7 instead of 4/7. The PE should be red as their PE is negative. Also, the Years of Positive Income should be 0 instead of 9 since they had negative EPS last year.

WFC - This one is still showing a denominator of 6.5. The only time we should have a 6.5 denominator is if we have current assets & liabilities to calculate Current Ratio, but are missing long term debt and unable to calculate LTD coverage ratio.

tydanielson commented 7 years ago

@drewengquist thanks for taking a look at these, we will want to split these out into multiple bugs for testing etc. I completely forgot about the P/B aggregate piece so that one makes sense, create a new bug for that. NOV with positive income are a total rather than a running historical amount so that's another bug to create. The other negative P/E on NOV is a bug too, so with that 3 total... WFC is covered in #10 so no need to recreate that one. As soon as you've created those 3 bugs go ahead and close this one.

drewengquist commented 7 years ago

I opened three new individual issues for the PVH PE-PB calculation, NOV negative PE, and NOV years consecutive positive income issues. I'll close this one out.